Horton

Switch "cl /?" to "cl /help" in MSVC scripts for platform detection

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 733d670073efd2c3a9df07c225006668009ab793
Author: Michael Paquier <michael@paquier.xyz>
Date: 2021-01-21T01:56:03Z
Releases: 14.0 
Switch "cl /?" to "cl /help" in MSVC scripts for platform detection

"cl /?" produces a different output if run on a real or a virtual drive
(this can be set with a simple subst command), causing an error in the
MSVC scripts if building on a virtual drive because the platform to use
cannot be detected.

"cl /help", on the contrary, produces a consistent output if used on a
real or virtual drive.  Changing to "/help" allows the compilation to
work with a virtual drive as long as the top of the code repository is
part of the drive, without impacting the build on real drives.

Reported-by: Robert Grange
Author: Juan José Santamaría Flecha
Discussion: https://postgr.es/m/16825-c4f104bcebc67034@postgresql.org

Files

PathChange+/−
src/tools/msvc/Solution.pm modified +1 −1

Discussion