Clean up cruft around collation initialization for tupdescs and scankeys.
Tom Lane <tgl@sss.pgh.pa.us>
Clean up cruft around collation initialization for tupdescs and scankeys. I found actual bugs in GiST and plpgsql; the rest of this is cosmetic but meant to decrease the odds of future bugs of omission.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/common/scankey.c | modified | +12 −13 |
| src/backend/access/common/tupdesc.c | modified | +7 −3 |
| src/backend/access/gin/ginutil.c | modified | +2 −0 |
| src/backend/access/gist/gistscan.c | modified | +8 −2 |
| src/backend/access/nbtree/nbtsearch.c | modified | +2 −4 |
| src/backend/access/nbtree/nbtutils.c | modified | +6 −2 |
| src/backend/commands/seclabel.c | modified | +0 −3 |
| src/backend/commands/sequence.c | modified | +10 −5 |
| src/backend/executor/nodeIndexscan.c | modified | +4 −6 |
| src/backend/executor/nodeMergeAppend.c | modified | +16 −14 |
| src/backend/utils/adt/pgstatfuncs.c | modified | +24 −12 |
| src/backend/utils/adt/selfuncs.c | modified | +1 −0 |
| src/backend/utils/cache/catcache.c | modified | +2 −0 |
| src/backend/utils/sort/tuplesort.c | modified | +16 −15 |
| src/include/access/skey.h | modified | +5 −2 |
| src/pl/plpgsql/src/pl_comp.c | modified | +4 −0 |