Fix mistakes in commit 4020b370f214315b8c10430301898ac21658143f
Robert Haas <rhaas@postgresql.org>
Fix mistakes in commit 4020b370f214315b8c10430301898ac21658143f cost_tidrangescan() was setting the disabled_nodes value correctly, and then immediately resetting it to zero, due to poor code editing on my part. materialized_finished_plan correctly set matpath.parent to zero, but forgot to also set matpath.parallel_workers = 0, causing an access to uninitialized memory in cost_material. (This shouldn't result in any real problem, but it makes valgrind unhappy.) reparameterize_path was dereferencing a variable before verifying that it was not NULL. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> (issue #1) Reported-by: Michael Paquier <michael@paquier.xyz> (issue #1) Diagnosed-by: Lukas Fittl <lukas@fittl.com> (issue #1) Reported-by: Zsolt Parragi <zsolt.parragi@percona.com> (issue #2) Reported-by: Richard Guo <guofenglinux@gmail.com> (issue #3) Discussion: http://postgr.es/m/CAN4CZFPvwjNJEZ_JT9Y67yR7C=KMNa=LNefOB8ZY7TKDcmAXOA@mail.gmail.com Discussion: http://postgr.es/m/aXrnPgrq6Gggb5TG@paquier.xyz
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/optimizer/path/costsize.c | modified | +0 −1 |
| src/backend/optimizer/plan/createplan.c | modified | +4 −1 |
| src/backend/optimizer/util/pathnode.c | modified | +2 −2 |
Discussion
- pg_plan_advice 219 messages · 2025-10-30 → 2026-06-10
Cited messages not in the archive:
aXrnPgrq6Gggb5TG@paquier.xyz