Code review for recent SQL/JSON commits
Alvaro Herrera <alvherre@alvh.no-ip.org>
Code review for recent SQL/JSON commits - At the last minute and for no particularly good reason, I changed the WITHOUT token to be marked especially for lookahead, from the one in WITHOUT TIME to the one in WITHOUT UNIQUE. Study of upcoming patches (where a new WITHOUT ARRAY WRAPPER clause is added) showed me that the former was better, so put it back the way the original patch had it. - update exprTypmod() for JsonConstructorExpr to return the typmod of the RETURNING clause, as a comment there suggested. Perhaps it's possible for this to make a difference with datetime types, but I didn't try to build a test case. - The nodeFuncs.c support code for new nodes was calling walker() directly instead of the WALK() macro as introduced by commit 1c27d16e6e5c. Modernize that. Also add exprLocation() support for a couple of nodes that missed it. Lastly, reorder the code more sensibly. The WITHOUT_LA -> WITHOUT change means that stored rules containing either WITHOUT TIME ZONE or WITHOUT UNIQUE KEYS would change representation. Therefore, bump catversion. Discussion: https://postgr.es/m/20230329181708.e64g2tpy7jyufqkr@alvherre.pgsql
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/nodes/nodeFuncs.c | modified | +257 −163 |
| src/backend/parser/gram.y | modified | +4 −4 |
| src/backend/parser/parser.c | modified | +2 −2 |
| src/include/catalog/catversion.h | modified | +1 −1 |
| src/interfaces/ecpg/preproc/parser.c | modified | +2 −2 |
Discussion
- SQL/JSON revisited 47 messages · 2022-12-28 → 2023-06-19