SQL/JSON: Always coerce JsonExpr result at runtime
Amit Langote <amitlan@postgresql.org>
SQL/JSON: Always coerce JsonExpr result at runtime Instead of looking up casts at parse time for converting the result of JsonPath* query functions to the specified or the default RETURNING type, always perform the conversion at runtime using either the target type's input function or the function json_populate_type(). There are two motivations for this change: 1. json_populate_type() coerces to types with typmod such that any string values that exceed length limit cause an error instead of silent truncation, which is necessary to be standard-conforming. 2. It was possible to end up with a cast expression that doesn't support soft handling of errors causing bugs in the of handling ON ERROR clause. JsonExpr.coercion_expr which would store the cast expression is no longer necessary, so remove. Bump catversion because stored rules change because of the above removal. Reported-by: Alvaro Herrera <alvherre@alvh.no-ip.org> Reviewed-by: Jian He <jian.universality@gmail.com> Discussion: Discussion: https://postgr.es/m/202405271326.5a5rprki64aw%40alvherre.pgsql
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execExpr.c | modified | +17 −35 |
| src/backend/executor/execExprInterp.c | modified | +23 −28 |
| src/backend/jit/llvm/llvmjit_expr.c | modified | +1 −1 |
| src/backend/nodes/nodeFuncs.c | modified | +2 −11 |
| src/backend/parser/parse_expr.c | modified | +35 −153 |
| src/backend/utils/adt/jsonfuncs.c | modified | +33 −15 |
| src/include/catalog/catversion.h | modified | +1 −1 |
| src/include/executor/execExpr.h | modified | +1 −0 |
| src/include/nodes/execnodes.h | modified | +2 −3 |
| src/include/nodes/primnodes.h | modified | +1 −7 |
| src/include/utils/jsonfuncs.h | modified | +1 −0 |
| src/test/regress/expected/sqljson_jsontable.out | modified | +21 −31 |
| src/test/regress/expected/sqljson_queryfuncs.out | modified | +54 −18 |
| src/test/regress/sql/sqljson_jsontable.sql | modified | +1 −1 |
| src/test/regress/sql/sqljson_queryfuncs.sql | modified | +20 −5 |
Discussion
- Re: pgsql: Add more SQL/JSON constructor functions 47 messages · 2024-05-27 → 2024-09-06