Horton

Remove unneeded casts of BufferGetPage() result

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 710e6c4301ee3c739a171ea12ed141b1f8df0d93
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2025-08-29T05:18:29Z
Releases: 19 (unreleased) 
Remove unneeded casts of BufferGetPage() result

BufferGetPage() already returns type Page, so casting it to Page
doesn't achieve anything.  A sizable number of call sites does this
casting; remove that.

This was already done inconsistently in the code in the first import
in 1996 (but didn't exist in the pre-1995 code), and it was then
apparently just copied around.

Author: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://www.postgresql.org/message-id/flat/CALdSSPgFhc5=vLqHdk-zCcnztC0zEY3EU_Q6a9vPEaw7FkE9Vw@mail.gmail.com

Files

PathChange+/−
contrib/amcheck/verify_gin.c modified +2 −2
contrib/bloom/blvacuum.c modified +1 −1
contrib/pgstattuple/pgstatindex.c modified +1 −1
contrib/pgstattuple/pgstattuple.c modified +2 −2
src/backend/access/brin/brin_xlog.c modified +6 −6
src/backend/access/gin/ginvacuum.c modified +1 −1
src/backend/access/gin/ginxlog.c modified +2 −2
src/backend/access/gist/gistbuild.c modified +2 −2
src/backend/access/gist/gist.c modified +7 −7
src/backend/access/gist/gistvacuum.c modified +2 −2
src/backend/access/gist/gistxlog.c modified +5 −5
src/backend/access/hash/hash_xlog.c modified +9 −9
src/backend/access/heap/heapam.c modified +1 −1
src/backend/access/heap/heapam_handler.c modified +1 −1
src/backend/access/heap/heapam_xlog.c modified +4 −4
src/backend/access/heap/pruneheap.c modified +1 −1
src/backend/access/heap/visibilitymap.c modified +1 −1
src/backend/access/nbtree/nbtxlog.c modified +14 −14
src/backend/access/spgist/spgvacuum.c modified +2 −2
src/backend/access/spgist/spgxlog.c modified +3 −3
src/backend/access/transam/xlogutils.c modified +1 −1
src/backend/commands/sequence.c modified +1 −1

Discussion