Replace TS_execute's TS_EXEC_CALC_NOT flag with TS_EXEC_SKIP_NOT.
Tom Lane <tgl@sss.pgh.pa.us>
Replace TS_execute's TS_EXEC_CALC_NOT flag with TS_EXEC_SKIP_NOT. It's fairly silly that ignoring NOT subexpressions is TS_execute's default behavior. It's wrong on its face and it encourages errors of omission. Moreover, the only two remaining callers that aren't specifying CALC_NOT are in ts_headline calculations, and it's very arguable that those are bugs: if you've specified "!foo" in your query, why would you want to get a headline that includes "foo"? Hence, rip that out and change the default behavior to be to calculate NOT accurately. As a concession to the slim chance that there is still somebody somewhere who needs the incorrect behavior, provide a new SKIP_NOT flag to explicitly request that. Back-patch into v13, mainly because it seems better to change this at the same time as the previous commit's rejiggering of TS_execute related APIs. Any outside callers affected by this change are probably also affected by that one. Discussion: https://postgr.es/m/CALT9ZEE-aLotzBg-pOp2GFTesGWVYzXA3=mZKzRDa_OKnLF7Mg@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/adt/tsginidx.c | modified | +2 −2 |
| src/backend/utils/adt/tsgistidx.c | modified | +2 −2 |
| src/backend/utils/adt/tsrank.c | modified | +1 −1 |
| src/backend/utils/adt/tsvector_op.c | modified | +4 −4 |
| src/include/tsearch/ts_utils.h | modified | +5 −3 |
Discussion
- [PATCH] fix GIN index search sometimes losing results 15 messages · 2020-05-07 → 2020-07-24