Fix some more bugs in signal handlers and process shutdown logic.
Tom Lane <tgl@sss.pgh.pa.us>
Fix some more bugs in signal handlers and process shutdown logic. WalSndKill was doing things exactly backwards: it should first clear MyWalSnd (to stop signal handlers from touching MyWalSnd->latch), then disown the latch, and only then mark the WalSnd struct unused by clearing its pid field. Also, WalRcvSigUsr1Handler and worker_spi_sighup failed to preserve errno, which is surely a requirement for any signal handler. Per discussion of recent buildfarm failures. Back-patch as far as the relevant code exists.
Files
| Path | Change | +/− |
|---|---|---|
| contrib/worker_spi/worker_spi.c | modified | +5 −1 |
| src/backend/replication/walreceiver.c | modified | +4 −0 |
| src/backend/replication/walsender.c | modified | +12 −6 |