Remove setvbuf() call from PQtrace()

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 6ec578e60101c3c02533f99715945a0400fb3286
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2021-03-31T23:11:51Z
Releases: 14.0
Remove setvbuf() call from PQtrace()

It's misplaced there -- it's not libpq's output stream to tweak in that
way.  In particular, POSIX says that it has to be called before any
other operation on the file, so if a stream previously used by the
calling application, bad things may happen.

Put setvbuf() in libpq_pipeline for good measure.

Also, reduce fopen(..., "w+") to just fopen(..., "w") in
libpq_pipeline.c.  It's not clear that this fixes anything, but we don't
use w+ anywhere.

Per complaints from Tom Lane.

Discussion: https://postgr.es/m/3337422.1617229905@sss.pgh.pa.us

Files

Discussion