Use --strip-unneeded when stripping static libraries with GNU strip.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 6dce37203410b011c0ccae40acf2649f79c38242
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-04-20T22:12:32Z
Releases: 13.11
Use --strip-unneeded when stripping static libraries with GNU strip.

We've long used "--strip-unneeded" for shared libraries but plain
"-x" for static libraries when stripping symbols with GNU strip.
There doesn't seem to be any really good reason for that though,
since --strip-unneeded produces smaller output (as "-x" alone
does not remove debug symbols).  Moreover it seems that
llvm-strip, although it identifies as GNU strip, misbehaves when
given "-x" for this purpose.  It's unclear whether that's
intentional or a bug in llvm-strip, but in any case it seems like
changing to use --strip-unneeded in all cases should be a win.

Note that this doesn't change our behavior when dealing with
non-GNU strip.

Per gripes from Ed Maste and Palle Girgensohn.  Back-patch,
in case anyone wants to use llvm-strip with stable branches.

Discussion: https://postgr.es/m/17898-5308d09543463266@postgresql.org
Discussion: https://postgr.es/m/20230420153338.bbj2g5jiyy3afhjz@awork3.anarazel.de

Files

PathChange+/−
config/programs.m4 modified +1 −1
configure modified +1 −1

Discussion