Fix MCV input array checks in statistics restore functions
Michael Paquier <michael@paquier.xyz>
Author:
Michael Paquier <michael@paquier.xyz>
Committer:
Noah Misch <noah@leadboat.com>
Date: 2026-05-11T12:13:46Z
Releases:
19 (unreleased)
Fix MCV input array checks in statistics restore functions The SQL functions for the restore of attribute and expression statistics accept "most_common_vals" and "most_common_freqs" as independent arrays. The planner assumes these have the same number of elements, but it was possible to insert in the catalogs data that would cause an over-read when the catalog data is loaded in the planner. There were two holes in the stats restore logic: - Both arrays should match in size. - The input array must be one-dimensional, and it should match with what is delivered by pg_dump when scanning the pg_stats catalogs. The multivariate extended statistics MCV path (import_mcv) already validated these inputs via check_mcvlist_array(), and is not affected. These problems exist in v18 and newer versions for the restore of attribute statistics. These problems affect only HEAD for the restore of the expression statistics. Reported-by: Jeroen Gui <jeroen.gui1@proton.me> Author: Michael Paquier <michael@paquier.xyz> Reviewed-by: Amit Langote <amitlangote09@gmail.com> Reviewed-by: John Naylor <johncnaylorls@gmail.com> Security: CVE-2026-6575 Backpatch-through: 18
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/statistics/attribute_stats.c | modified | +21 −4 |
| src/backend/statistics/extended_stats_funcs.c | modified | +26 −0 |
| src/backend/statistics/stat_utils.c | modified | +9 −0 |
| src/test/regress/expected/stats_import.out | modified | +116 −1 |
| src/test/regress/sql/stats_import.sql | modified | +76 −0 |