Clean up and document the API for XLogOpenRelation and XLogReadBuffer.
Tom Lane <tgl@sss.pgh.pa.us>
Clean up and document the API for XLogOpenRelation and XLogReadBuffer. This commit doesn't make much functional change, but it does eliminate some duplicated code --- for instance, PageIsNew tests are now done inside XLogReadBuffer rather than by each caller. The GIST xlog code still needs a lot of love, but I'll worry about that separately.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/gist/gistxlog.c | modified | +16 −47 |
| src/backend/access/heap/heapam.c | modified | +93 −90 |
| src/backend/access/nbtree/nbtxlog.c | modified | +129 −155 |
| src/backend/access/transam/README | modified | +164 −1 |
| src/backend/access/transam/xact.c | modified | +3 −3 |
| src/backend/access/transam/xlog.c | modified | +26 −38 |
| src/backend/access/transam/xlogutils.c | modified | +85 −23 |
| src/backend/commands/dbcommands.c | modified | +11 −6 |
| src/backend/commands/sequence.c | modified | +3 −9 |
| src/backend/commands/tablespace.c | modified | +7 −1 |
| src/backend/storage/buffer/bufmgr.c | modified | +3 −3 |
| src/backend/utils/init/postinit.c | modified | +2 −2 |
| src/include/access/xlogutils.h | modified | +4 −3 |
| src/include/storage/bufmgr.h | modified | +2 −2 |