Move I/O before the index_update_stats() buffer lock region.
Noah Misch <noah@leadboat.com>
Move I/O before the index_update_stats() buffer lock region. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 enlarged the work done here under the pg_class heap buffer lock. Two preexisting actions are best done before holding that lock. Both RelationGetNumberOfBlocks() and visibilitymap_count() do I/O, and the latter might exclusive-lock a visibility map buffer. Moving these reduces contention and risk of undetected LWLock deadlock. Back-patch to v12, like that commit. Discussion: https://postgr.es/m/20241031200139.b4@rfd.leadboat.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/index.c | modified | +36 −18 |
Discussion
- Inval reliability, especially for inplace updates 41 messages · 2024-05-23 → 2026-02-17