Refrain from duplicating data in reorderbuffers

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 6d30e3a2b6b7ce260b3b8bff5ad44c5b6a924b32
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2018-03-06T19:10:23Z
Releases: 9.4.18
Refrain from duplicating data in reorderbuffers

If a walsender exits leaving data in reorderbuffers, the next walsender
that tries to decode the same transaction would append its decoded data
in the same spill files without truncating it first, which effectively
duplicate the data.  Avoid that by removing any leftover reorderbuffer
spill files when a walsender starts.

Backpatch to 9.4; this bug has been there from the very beginning of
logical decoding.

Author: Craig Ringer, revised by me
Reviewed by: Álvaro Herrera, Petr Jelínek, Masahiko Sawada

Files

PathChange+/−
src/backend/replication/logical/reorderbuffer.c modified +82 −55