Fix bogus ctid requirement for dummy-root partitioned targets
Amit Langote <amitlan@postgresql.org>
Fix bogus ctid requirement for dummy-root partitioned targets ExecInitModifyTable() unconditionally required a ctid junk column even when the target was a partitioned table. This led to spurious "could not find junk ctid column" errors when all children were excluded and only the dummy root result relation remained. A partitioned table only appears in the result relations list when all leaf partitions have been pruned, leaving the dummy root as the sole entry. Assert this invariant (nrels == 1) and skip the ctid requirement. Also adjust ExecModifyTable() to tolerate invalid ri_RowIdAttNo for partitioned tables, which is safe since no rows will be processed in this case. Bug: #19099 Reported-by: Alexander Lakhin <exclusion@gmail.com> Author: Amit Langote <amitlangote09@gmail.com> Reviewed-by: Tender Wang <tndrwang@gmail.com> Reviewed-by: Kirill Reshke <reshkekirill@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19099-e05dcfa022fe553d%40postgresql.org Backpatch-through: 14
Files
| Path | Change | +/− |
|---|---|---|
| contrib/file_fdw/input/file_fdw.source | modified | +14 −0 |
| contrib/file_fdw/output/file_fdw.source | modified | +11 −0 |
| src/backend/executor/nodeModifyTable.c | modified | +16 −3 |
Discussion
- BUG #19099: Conditional DELETE from partitioned table with non-updatable partition raises internal error 36 messages · 2025-10-29 → 2026-01-23