Horton

Convert misleading while loop into an if condition

David Rowley <drowley@postgresql.org>

View on postgr.es
Commit: 6cb93beddd33d00e0ce2ee55edfa32cd2a935394
Author: David Rowley <drowley@postgresql.org>
Date: 2021-05-14T00:26:11Z
Releases: 14.0 
Convert misleading while loop into an if condition

This seems to be leftover from ea15e1867 and from when we used to evaluate
SRFs at each node.

Since there is an unconditional "return" at the end of the loop body, only
1 loop is ever possible, so we can just change this into an if condition.

There is no actual bug being fixed here so no back-patch. It seems fine to
just fix this anomaly in master only.

Author: Greg Nancarrow
Discussion: https://postgr.es/m/CAJcOf-d7T1q0az-D8evWXnsuBZjigT04WkV5hCAOEJQZRWy28w@mail.gmail.com

Files

PathChange+/−
src/backend/executor/nodeResult.c modified +1 −1

Discussion