Horton

Ensure correct lock level is used in ALTER ... RENAME

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 6c8d1c197bd67e78c12c68d8f0bd111a59e7bccd
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2021-10-19T22:08:45Z
Releases: 12.9 
Ensure correct lock level is used in ALTER ... RENAME

Commit 1b5d797cd4f7 intended to relax the lock level used to rename
indexes, but inadvertently allowed *any* relation to be renamed with a
lowered lock level, as long as the command is spelled ALTER INDEX.
That's undesirable for other relation types, so retry the operation with
the higher lock if the relation turns out not to be an index.

After this fix, ALTER INDEX <sometable> RENAME will require access
exclusive lock, which it didn't before.

Author: Nathan Bossart <bossartn@amazon.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reported-by: Onder Kalaci <onderk@microsoft.com>
Discussion: https://postgr.es/m/PH0PR21MB1328189E2821CDEC646F8178D8AE9@PH0PR21MB1328.namprd21.prod.outlook.com

Files

PathChange+/−
src/backend/commands/tablecmds.c modified +48 −14
src/test/regress/expected/alter_table.out modified +48 −0
src/test/regress/sql/alter_table.sql modified +31 −0

Discussion