Minor cleanup of the BRIN parallel build code
Tomas Vondra <tomas.vondra@postgresql.org>
Minor cleanup of the BRIN parallel build code Commit b437571714 added support for parallel builds for BRIN indexes, using code similar to BTREE parallel builds, and also a new tuplesort variant. This commit simplifies the new code in two ways: * The "spool" grouping tuplesort and the heap/index is not necessary. The heap/index are available as separate arguments, causing confusion. So remove the spool, and use the tuplesort directly. * The new tuplesort variant does not need the heap/index, as it sorts simply by the range block number, without accessing the tuple data. So simplify that too. Initial report and patch by Ranier Vilela, further cleanup by me. Author: Ranier Vilela Discussion: https://postgr.es/m/CAEudQAqD7f2i4iyEaAz-5o-bf6zXVX-AkNUBm-YjUXEemaEh6A%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/brin/brin.c | modified | +36 −62 |
| src/backend/utils/sort/tuplesortvariants.c | modified | +2 −24 |
| src/include/utils/tuplesort.h | modified | +1 −3 |
| src/tools/pgindent/typedefs.list | modified | +0 −1 |
Discussion
- Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) 11 messages · 2023-12-26 → 2023-12-30