Redesign PlanForeignScan API to allow multiple paths for a foreign table.
Tom Lane <tgl@sss.pgh.pa.us>
Redesign PlanForeignScan API to allow multiple paths for a foreign table. The original API specification only allowed an FDW to create a single access path, which doesn't seem like a terribly good idea in hindsight. Instead, move the responsibility for building the Path node and calling add_path() into the FDW's PlanForeignScan function. Now, it can do that more than once if appropriate. There is no longer any need for the transient FdwPlan struct, so get rid of that. Etsuro Fujita, Shigeru Hanada, Tom Lane
Files
| Path | Change | +/− |
|---|---|---|
| contrib/file_fdw/file_fdw.c | modified | +30 −9 |
| doc/src/sgml/fdwhandler.sgml | modified | +21 −12 |
| src/backend/nodes/copyfuncs.c | modified | +2 −19 |
| src/backend/nodes/outfuncs.c | modified | +4 −15 |
| src/backend/optimizer/path/allpaths.c | modified | +8 −4 |
| src/backend/optimizer/plan/createplan.c | modified | +4 −5 |
| src/backend/optimizer/util/pathnode.c | modified | +17 −23 |
| src/include/foreign/fdwapi.h | modified | +3 −32 |
| src/include/nodes/nodes.h | modified | +0 −1 |
| src/include/nodes/plannodes.h | modified | +1 −2 |
| src/include/nodes/relation.h | modified | +8 −2 |
| src/include/optimizer/pathnode.h | modified | +5 −1 |