Fix exception safety bug in typcache.c.
Thomas Munro <tmunro@postgresql.org>
Fix exception safety bug in typcache.c. If an out-of-memory error was thrown at an unfortunate time, ensure_record_cache_typmod_slot_exists() could leak memory and leave behind a global state that produced an infinite loop on the next call. Fix by merging RecordCacheArray and RecordIdentifierArray into a single array. With only one allocation or re-allocation, there is no intermediate state. Back-patch to all supported releases. Reported-by: "James Pang (chaolpan)" <chaolpan@cisco.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/PH0PR11MB519113E738814BDDA702EDADD6EFA%40PH0PR11MB5191.namprd11.prod.outlook.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/cache/typcache.c | modified | +26 −26 |
| src/tools/pgindent/typedefs.list | modified | +1 −0 |
Discussion
- query pg_stat_ssl hang 100%cpu 18 messages · 2023-09-06 → 2023-09-13