Fix netmask handling in inet_minmax_multi_ops
Tomas Vondra <tomas.vondra@postgresql.org>
Fix netmask handling in inet_minmax_multi_ops When calculating distance in brin_minmax_multi_distance_inet(), the netmask was applied incorrectly. This results in (seemingly) incorrect ordering of values, triggering an assert. For builds without asserts this is mostly harmless - we may merge other ranges, possibly resulting in slightly less efficient index. But it's still correct and the greedy algorithm doesn't guarantee optimality anyway. Backpatch to 14, where minmax-multi indexes were introduced. Reported by Dmitry Dolgov, investigation and fix by me. Reported-by: Dmitry Dolgov Backpatch-through: 14 Discussion: https://postgr.es/m/17774-c6f3e36dd4471e67@postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/brin/brin_minmax_multi.c | modified | +2 −2 |
| src/test/regress/expected/brin_multi.out | modified | +6 −0 |
| src/test/regress/sql/brin_multi.sql | modified | +7 −0 |
Discussion
- BUG #17774: Assert triggered on brin_minmax_multi.c 13 messages · 2023-02-06 → 2023-03-20