Unwind some workarounds for lack of portable int64 format specifier
Peter Eisentraut <peter@eisentraut.org>
Unwind some workarounds for lack of portable int64 format specifier Because there is no portable int64/uint64 format specifier and we can't stick macros like INT64_FORMAT into the middle of a translatable string, we have been using various workarounds that put the number to be printed into a string buffer first. Now that we always use our own sprintf(), we can rely on %lld and %llu to work, so we can use those. This patch undoes this workaround in a few places where it was egregiously verbose. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/CAH2-Wz%3DWbNxc5ob5NJ9yqo2RMJ0q4HXDS30GVCobeCvC9A1L9A%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/transam/xlogreader.c | modified | +3 −13 |
| src/backend/replication/basebackup.c | modified | +3 −8 |
| src/bin/pg_controldata/pg_controldata.c | modified | +2 −10 |
| src/bin/pg_resetwal/pg_resetwal.c | modified | +2 −11 |
| src/bin/pg_rewind/libpq_fetch.c | modified | +2 −8 |
| src/bin/pg_test_timing/pg_test_timing.c | modified | +3 −9 |
Discussion
- "long" type is not appropriate for counting tuples 36 messages · 2019-04-28 → 2019-09-06