Horton

Don't include utils/array.h from acl.h.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: 6a04d345fd8094058f08344af93022566222733a
Author: Andres Freund <andres@anarazel.de>
Date: 2019-08-16T17:33:30Z
Releases: 13.0 
Don't include utils/array.h from acl.h.

For most uses of acl.h the details of how "Acl" internally looks like
are irrelevant. It might make sense to move a lot of the
implementation details into a separate header at a later point.

The main motivation of this change is to avoid including fmgr.h (via
array.h, which needs it for exposed structs) in a lot of files that
otherwise don't need it. A subsequent commit will remove the fmgr.h
include from a lot of files.

Directly include utils/array.h and utils/expandeddatum.h from the
files that need them, but previously included them indirectly, via
acl.h.

Author: Andres Freund
Discussion: https://postgr.es/m/20190803193733.g3l3x3o42uv4qj7l@alap3.anarazel.de

Files

PathChange+/−
contrib/pageinspect/hashfuncs.c modified +1 −0
src/backend/executor/execExpr.c modified +1 −0
src/backend/executor/execExprInterp.c modified +1 −0
src/backend/executor/execTuples.c modified +1 −0
src/backend/executor/nodeAgg.c modified +1 −0
src/backend/executor/nodeWindowAgg.c modified +1 −0
src/backend/partitioning/partprune.c modified +1 −0
src/backend/statistics/extended_stats.c modified +1 −0
src/backend/statistics/mcv.c modified +1 −0
src/backend/utils/adt/acl.c modified +1 −0
src/backend/utils/adt/tsvector_op.c modified +1 −0
src/include/catalog/objectaddress.h modified +1 −1
src/include/utils/acl.h modified +1 −2
src/include/utils/array.h modified +1 −1

Discussion