Further code review for pg_lsn data type.

Robert Haas <rhaas@postgresql.org>

Commit: 694e3d139a9d090c58494428bebfadad216419da
Author: Robert Haas <rhaas@postgresql.org>
Date: 2014-02-19T15:06:59Z
Releases: 9.4.0
Further code review for pg_lsn data type.

Change input function error messages to be more consistent with what is
done elsewhere.  Remove a bunch of redundant type casts, so that the
compiler will warn us if we screw up.  Don't pass LSNs by value on
platforms where a Datum is only 32 bytes, per buildfarm.  Move macros
for packing and unpacking LSNs to pg_lsn.h so that we can include
access/xlogdefs.h, to avoid an unsatisfied dependency on XLogRecPtr.

Files

PathChange+/−
src/backend/utils/adt/pg_lsn.c modified +19 −19
src/include/catalog/pg_type.h modified +1 −1
src/include/fmgr.h modified +0 −2
src/include/postgres.h modified +0 −14
src/include/utils/pg_lsn.h modified +7 −0
src/test/regress/expected/pg_lsn.out modified +5 −5