Make rs_cindex and rs_ntuples unsigned
Melanie Plageman <melanieplageman@gmail.com>
Make rs_cindex and rs_ntuples unsigned HeapScanDescData.rs_cindex and rs_ntuples can't be less than 0. All scan types using the heap scan descriptor expect these values to be >= 0. Make that expectation clear by making rs_cindex and rs_ntuples unsigned. Also remove the test in heapam_scan_bitmap_next_tuple() that checks if rs_cindex < 0. This was never true, but now that rs_cindex is unsigned, it makes even less sense. While we are at it, initialize both rs_cindex and rs_ntuples to 0 in initscan(). Author: Melanie Plageman Reviewed-by: Dilip Kumar Discussion: https://postgr.es/m/CAAKRu_ZxF8cDCM_BFi_L-t%3DRjdCZYP1usd1Gd45mjHfZxm0nZw%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/heap/heapam.c | modified | +5 −2 |
| src/backend/access/heap/heapam_handler.c | modified | +1 −1 |
| src/include/access/heapam.h | modified | +2 −2 |
Discussion
- Can rs_cindex be < 0 for bitmap heap scans? 21 messages · 2024-10-23 → 2024-12-20