Horton

Fix wrong assertion and poor error messages in "COPY (query) TO".

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 68ad9816c189958a0731d8d5ead7545878fdf15d
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-10-21T19:08:22Z
Releases: 18.0 
Fix wrong assertion and poor error messages in "COPY (query) TO".

If the query is rewritten into a NOTIFY command by a DO INSTEAD
rule, we'd get an assertion failure, or in non-assert builds
issue a rather confusing error message.  Improve that.

Also fix a longstanding grammar mistake in a nearby error message.

Per bug #18664 from Alexander Lakhin.  Back-patch to all supported
branches.

Tender Wang and Tom Lane

Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org

Files

PathChange+/−
src/backend/commands/copyto.c modified +6 −2
src/test/regress/expected/copydml.out modified +7 −3
src/test/regress/sql/copydml.sql modified +4 −0

Discussion