Horton

Remove --disable-thread-safety and related code.

Thomas Munro <tmunro@postgresql.org>

View on postgr.es
Commit: 68a4b58eca032916e2aad78d63f717dcb147e906
Author: Thomas Munro <tmunro@postgresql.org>
Date: 2023-07-11T20:20:43Z
Releases: 17.0 
Remove --disable-thread-safety and related code.

All supported computers have either POSIX or Windows threads, and we no
longer have any automated testing of --disable-thread-safety.  We define
a vestigial ENABLE_THREAD_SAFETY macro to 1 in ecpg_config.h in case it
is useful, but we no longer test it anywhere in PostgreSQL code, and
associated dead code paths are removed.

The Meson and perl-based Windows build scripts never had an equivalent
build option.

Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/CA%2BhUKGLtmexrpMtxBRLCVePqV_dtWG-ZsEbyPrYc%2BNBB2TkNsw%40mail.gmail.com

Files

PathChange+/−
configure modified +5 −49
configure.ac modified +5 −21
doc/src/sgml/installation.sgml modified +0 −13
meson.build modified +0 −11
src/bin/pgbench/pgbench.c modified +1 −21
src/include/pg_config.h.in modified +0 −4
src/interfaces/ecpg/ecpglib/connect.c modified +0 −40
src/interfaces/ecpg/ecpglib/descriptor.c modified +0 −10
src/interfaces/ecpg/ecpglib/ecpglib_extern.h modified +0 −2
src/interfaces/ecpg/ecpglib/execute.c modified +0 −2
src/interfaces/ecpg/ecpglib/memory.c modified +0 −7
src/interfaces/ecpg/ecpglib/misc.c modified +0 −47
src/interfaces/ecpg/include/ecpg_config.h.in modified +2 −3
src/interfaces/ecpg/include/ecpglib.h modified +0 −2
src/interfaces/ecpg/include/ecpg-pthread-win32.h modified +0 −3
src/interfaces/ecpg/include/meson.build modified +2 −1
src/interfaces/ecpg/test/expected/thread-alloc.c modified +17 −26
src/interfaces/ecpg/test/expected/thread-descriptor.c modified +8 −14
src/interfaces/ecpg/test/expected/thread-prep.c modified +31 −40
src/interfaces/ecpg/test/expected/thread-thread.c modified +27 −36
src/interfaces/ecpg/test/expected/thread-thread_implicit.c modified +27 −36
src/interfaces/ecpg/test/thread/alloc.pgc modified +0 −9
src/interfaces/ecpg/test/thread/descriptor.pgc modified +1 −7
src/interfaces/ecpg/test/thread/prep.pgc modified +0 −9
src/interfaces/ecpg/test/thread/thread_implicit.pgc modified +0 −9
src/interfaces/ecpg/test/thread/thread.pgc modified +0 −9
src/interfaces/libpq/fe-connect.c modified +0 −4
src/interfaces/libpq/fe-exec.c modified +0 −4
src/interfaces/libpq/fe-print.c modified +1 −12
src/interfaces/libpq/fe-secure.c modified +2 −24
src/interfaces/libpq/fe-secure-openssl.c modified +3 −14
src/interfaces/libpq/legacy-pqsignal.c modified +1 −3
src/interfaces/libpq/libpq-int.h modified +1 −8
src/interfaces/libpq/Makefile modified +1 −4
src/Makefile.global.in modified +0 −1
src/makefiles/meson.build modified +0 −1
src/tools/msvc/ecpg_regression.proj modified +1 −1
src/tools/msvc/Solution.pm modified +1 −2

Documentation touched

Discussion