Avoid calling kill() in a postmaster signal handler.

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 6887067b6d741ef35cae851f656a54f21e8c65e2
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2009-08-24T17:23:17Z
Releases: 8.4.1
Avoid calling kill() in a postmaster signal handler.

This causes problems when the system load is high, per report from Zdenek
Kotala in <1250860954.1239.114.camel@localhost>; instead of calling kill
directly, have the signal handler set a flag which is checked in ServerLoop.
This way, the handler can return before being called again by a subsequent
signal sent from the autovacuum launcher.  Also, increase the sleep in the
launcher in this failure path to 1 second.

Backpatch to 8.3, which is when the signalling between autovacuum
launcher/postmaster was introduced.

Also, add a couple of ReleasePostmasterChildSlot calls in error paths; this
part backpatched to 8.4 which is when the child slot stuff was introduced.

Files

PathChange+/−
src/backend/postmaster/autovacuum.c modified +2 −2
src/backend/postmaster/postmaster.c modified +19 −3