Horton

Report NULL as total backup size if it's not estimated.

Fujii Masao <fujii@postgresql.org>

View on postgr.es
Commit: 67e0adfb3f98f1e4a89a32b6f2e59774ce579146
Author: Fujii Masao <fujii@postgresql.org>
Date: 2020-03-24T01:43:41Z
Releases: 13.0 
Report NULL as total backup size if it's not estimated.

Previously 0 was reported in pg_stat_progress_basebackup.total_backup
if the total backup size was not estimated. Per discussion, our consensus
is that NULL is better choise as the value in total_backup in that case.
So this commit makes pg_stat_progress_basebackup view report NULL
in total_backup column if the estimation is disabled.

Bump catversion.

Author: Fujii Masao
Reviewed-by: Amit Langote, Magnus Hagander, Alvaro Herrera
Discussion: https://postgr.es/m/CABUevExnhOD89zBDuPvfAAh243RzNpwCPEWNLtMYpKHMB8gbAQ@mail.gmail.com

Files

PathChange+/−
doc/src/sgml/monitoring.sgml modified +1 −1
doc/src/sgml/ref/pg_basebackup.sgml modified +1 −1
src/backend/catalog/system_views.sql modified +1 −1
src/backend/replication/basebackup.c modified +17 −2
src/include/catalog/catversion.h modified +1 −1
src/test/regress/expected/rules.out modified +4 −1

Documentation touched

Discussion