Preliminary cleanup for hash index code (doesn't attack the locking problem
Tom Lane <tgl@sss.pgh.pa.us>
Preliminary cleanup for hash index code (doesn't attack the locking problem yet). Fix a couple of bugs that would only appear if multiple bitmap pages are used, including a buffer reference leak and incorrect computation of bit indexes. Get rid of 'overflow address' concept, which accomplished nothing except obfuscating the code and creating a risk of failure due to limited range of offset field. Rename some misleadingly-named fields and routines, and improve documentation.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/hash/hashinsert.c | modified | +6 −9 |
| src/backend/access/hash/hashovfl.c | modified | +179 −211 |
| src/backend/access/hash/hashpage.c | modified | +118 −125 |
| src/include/access/hash.h | modified | +61 −105 |