Don't set a fast default for anything but a plain table

Andrew Dunstan <andrew@dunslane.net>

Commit: 6432bfe8a372a1c1d4ee8edc91be7fe9910bf51d
Author: Andrew Dunstan <andrew@dunslane.net>
Date: 2021-06-18T11:46:21Z
Releases: 12.8
Don't set a fast default for anything but a plain table

The fast default code added in Release 11 omitted to check that the
table a fast default was being added to was a plain table. Thus one
could be added to a foreign table, which predicably blows up. Here we
perform that check.

In addition, on the back branches, since some of these might have
escaped into the wild, if we encounter a missing value for
an attribute of something other than a plain table we ignore it.

Fixes bug #17056

Backpatch to release 11,

Reviewed by: Andres Freund, Álvaro Herrera and Tom Lane

Files