Fix incorrect logic in plan dependency recording

David Rowley <drowley@postgresql.org>

Commit: 6341cb0b02ae16d7bbb8b4e7ebabf80c551a685e
Author: David Rowley <drowley@postgresql.org>
Date: 2023-09-13T23:27:43Z
Releases: 14.10
Fix incorrect logic in plan dependency recording

Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency
on a function but mistakenly inverted the OidIsValid test.  This meant
that we'd record a dependency only when the function's Oid was
InvalidOid.  Clearly this was meant to *not* record the dependency in
that case.

50e17ad28 made this mistake first, then in v15 29f45e299 copied the same
mistake.

Reported-by: Tom Lane
Backpatch-through: 14, where 50e17ad28 first made this mistake
Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us

Files

PathChange+/−
src/backend/optimizer/plan/setrefs.c modified +1 −1

Discussion