Disallow whole-row variables in GENERATED expressions.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 61feb8670824c8dfb66094f2a87df2395be0665c
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-05-21T19:12:37Z
Releases: 12.8
Disallow whole-row variables in GENERATED expressions.

This was previously allowed, but I think that was just an oversight.
It's a clear violation of the rule that a generated column cannot
depend on itself or other generated columns.  Moreover, because the
code was relying on the assumption that no such cross-references
exist, it was pretty easy to crash ALTER TABLE and perhaps other
places.  Even if you managed not to crash, you got quite unstable,
implementation-dependent results.

Per report from Vitaly Ustinov.
Back-patch to v12 where GENERATED came in.

Discussion: https://postgr.es/m/CAM_DEiWR2DPT6U4xb-Ehigozzd3n3G37ZB1+867zbsEVtYoJww@mail.gmail.com

Files

Discussion