Horton

Split ecpg_execute() in constituent parts

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 61bee9f756ce875f3b678099a6bb9654bd2fa21a
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2014-01-16T21:06:50Z
Releases: 9.4.0 
Split ecpg_execute() in constituent parts

Split the rather long ecpg_execute() function into ecpg_build_params(),
ecpg_autostart_transaction(), a smaller ecpg_execute() and
ecpg_process_output().  There is no user-visible change here, only code
reorganization to support future patches.

Author: Zoltán Böszörményi

Reviewed by Antonin Houska.  Larger, older versions of this patch were
reviewed by Noah Misch and Michael Meskes.

Files

PathChange+/−
src/interfaces/ecpg/ecpglib/execute.c modified +136 −72
src/interfaces/ecpg/ecpglib/extern.h modified +6 −1
src/interfaces/ecpg/test/expected/compat_informix-describe.stderr modified +7 −7
src/interfaces/ecpg/test/expected/compat_informix-rnull.stderr modified +6 −6
src/interfaces/ecpg/test/expected/compat_informix-sqlda.stderr modified +34 −34
src/interfaces/ecpg/test/expected/compat_informix-test_informix2.stderr modified +7 −7
src/interfaces/ecpg/test/expected/compat_informix-test_informix.stderr modified +12 −12
src/interfaces/ecpg/test/expected/connect-test2.stderr modified +5 −5
src/interfaces/ecpg/test/expected/connect-test3.stderr modified +2 −2
src/interfaces/ecpg/test/expected/connect-test5.stderr modified +1 −1
src/interfaces/ecpg/test/expected/pgtypeslib-dt_test.stderr modified +5 −5
src/interfaces/ecpg/test/expected/pgtypeslib-nan_test.stderr modified +37 −37
src/interfaces/ecpg/test/expected/pgtypeslib-num_test.stderr modified +3 −3
src/interfaces/ecpg/test/expected/preproc-array_of_struct.stderr modified +8 −8
src/interfaces/ecpg/test/expected/preproc-autoprep.stderr modified +34 −34
src/interfaces/ecpg/test/expected/preproc-cursor.stderr modified +48 −48
src/interfaces/ecpg/test/expected/preproc-define.stderr modified +5 −5
src/interfaces/ecpg/test/expected/preproc-outofscope.stderr modified +12 −12
src/interfaces/ecpg/test/expected/preproc-strings.stderr modified +2 −2
src/interfaces/ecpg/test/expected/preproc-type.stderr modified +3 −3
src/interfaces/ecpg/test/expected/preproc-variable.stderr modified +16 −16
src/interfaces/ecpg/test/expected/preproc-whenever.stderr modified +4 −4
src/interfaces/ecpg/test/expected/sql-array.stderr modified +8 −8
src/interfaces/ecpg/test/expected/sql-binary.stderr modified +12 −12
src/interfaces/ecpg/test/expected/sql-code100.stderr modified +15 −15
src/interfaces/ecpg/test/expected/sql-copystdout.stderr modified +6 −6
src/interfaces/ecpg/test/expected/sql-define.stderr modified +7 −7
src/interfaces/ecpg/test/expected/sql-describe.stderr modified +7 −7
src/interfaces/ecpg/test/expected/sql-desc.stderr modified +14 −14
src/interfaces/ecpg/test/expected/sql-dynalloc2.stderr modified +10 −10
src/interfaces/ecpg/test/expected/sql-dynalloc.stderr modified +6 −6
src/interfaces/ecpg/test/expected/sql-dyntest.stderr modified +11 −11
src/interfaces/ecpg/test/expected/sql-execute.stderr modified +13 −13
src/interfaces/ecpg/test/expected/sql-fetch.stderr modified +19 −19
src/interfaces/ecpg/test/expected/sql-func.stderr modified +11 −11
src/interfaces/ecpg/test/expected/sql-indicators.stderr modified +10 −10
src/interfaces/ecpg/test/expected/sql-insupd.stderr modified +8 −8
src/interfaces/ecpg/test/expected/sql-oldexec.stderr modified +12 −12
src/interfaces/ecpg/test/expected/sql-parser.stderr modified +6 −6
src/interfaces/ecpg/test/expected/sql-quote.stderr modified +16 −16
src/interfaces/ecpg/test/expected/sql-show.stderr modified +10 −10
src/interfaces/ecpg/test/expected/sql-sqlda.stderr modified +31 −31