Don't clear btpo_cycleid during _bt_vacuum_one_page.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 6182e01f18f71c48915e2aebb20362294de6e677
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-02-21T20:03:44Z
Releases: 9.1.3
Don't clear btpo_cycleid during _bt_vacuum_one_page.

When "vacuuming" a single btree page by removing LP_DEAD tuples, we are not
actually within a vacuum operation, but rather in an ordinary insertion
process that could well be running concurrently with a vacuum.  So clearing
the cycleid is incorrect, and could cause the concurrent vacuum to miss
removing tuples that it needs to remove.  This is a longstanding bug
introduced by commit e6284649b9e30372b3990107a082bc7520325676 of
2006-07-25.  I believe it explains Maxim Boguk's recent report of index
corruption, and probably some other previously unexplained reports.

In 9.0 and up this is a one-line fix; before that we need to introduce a
flag to tell _bt_delitems what to do.

Files

PathChange+/−
src/backend/access/nbtree/nbtpage.c modified +3 −4