Fix race condition between hot standby and restoring a full-page image.
Heikki Linnakangas <heikki.linnakangas@iki.fi>
Fix race condition between hot standby and restoring a full-page image. There was a window in RestoreBackupBlock where a page would be zeroed out, but not yet locked. If a backend pinned and locked the page in that window, it saw the zeroed page instead of the old page or new page contents, which could lead to missing rows in a result set, or errors. To fix, replace RBM_ZERO with RBM_ZERO_AND_LOCK, which atomically pins, zeroes, and locks the page, if it's not in the buffer cache already. In stable branches, the old RBM_ZERO constant is renamed to RBM_DO_NOT_USE, to avoid breaking any 3rd party extensions that might use RBM_ZERO. More importantly, this avoids renumbering the other enum values, which would cause even bigger confusion in extensions that use ReadBufferExtended, but haven't been recompiled. Backpatch to all supported versions; this has been racy since hot standby was introduced.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/hash/hashpage.c | modified | +7 −6 |
| src/backend/access/heap/heapam.c | modified | +1 −2 |
| src/backend/access/transam/xlog.c | modified | +1 −5 |
| src/backend/access/transam/xlogutils.c | modified | +12 −5 |
| src/backend/storage/buffer/bufmgr.c | modified | +37 −4 |
| src/include/storage/bufmgr.h | modified | +8 −3 |