Fix Y2038 issues with MyStartTime.
Nathan Bossart <nathan@postgresql.org>
Fix Y2038 issues with MyStartTime. Several places treat MyStartTime as a "long", which is only 32 bits wide on some platforms. In reality, MyStartTime is a pg_time_t, i.e., a signed 64-bit integer. This will lead to interesting bugs on the aforementioned systems in 2038 when signed 32-bit integers are no longer sufficient to store Unix time (e.g., "pg_ctl start" hanging). To fix, ensure that MyStartTime is handled as a 64-bit value everywhere. (Of course, users will need to ensure that time_t is 64 bits wide on their system, too.) Co-authored-by: Max Johnson Discussion: https://postgr.es/m/CO1PR07MB905262E8AC270FAAACED66008D682%40CO1PR07MB9052.namprd07.prod.outlook.com Backpatch-through: 12
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/error/elog.c | modified | +4 −4 |
| src/backend/utils/init/miscinit.c | modified | +2 −2 |
| src/bin/pg_ctl/pg_ctl.c | modified | +1 −1 |
Discussion
- pg_ctl/miscinit: print "MyStartTime" as a long long instead of long to avoid 2038 problem. 14 messages · 2024-09-24 → 2024-11-22