Horton

Initial pgindent and pgperltidy run for v13.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 5cbfce562f7cd2aab0cdc4694ce298ec3567930e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-05-14T17:06:50Z
Releases: 13.0 
Initial pgindent and pgperltidy run for v13.

Includes some manual cleanup of places that pgindent messed up,
most of which weren't per project style anyway.

Notably, it seems some people didn't absorb the style rules of
commit c9d297751, because there were a bunch of new occurrences
of function calls with a newline just after the left paren, all
with faulty expectations about how the rest of the call would get
indented.

Files

PathChange+/−
contrib/adminpack/adminpack.c modified +1 −1
contrib/intarray/_int_bool.c modified +2 −2
contrib/ltree/_ltree_gist.c modified +2 −2
contrib/ltree/ltree_gist.c modified +3 −3
contrib/ltree/ltree.h modified +1 −1
contrib/pg_stat_statements/pg_stat_statements.c modified +1 −0
contrib/pg_visibility/pg_visibility.c modified +1 −1
contrib/postgres_fdw/connection.c modified +3 −2
contrib/postgres_fdw/option.c modified +6 −6
doc/src/sgml/mk_feature_tables.pl modified +4 −2
src/backend/access/common/detoast.c modified +10 −9
src/backend/access/gist/gist.c modified +6 −5
src/backend/access/hash/hashutil.c modified +1 −0
src/backend/access/hash/hashvalidate.c modified +1 −1
src/backend/access/heap/heapam.c modified +2 −2
src/backend/access/index/indexam.c modified +2 −2
src/backend/access/nbtree/nbtpage.c modified +8 −5
src/backend/access/nbtree/nbtree.c modified +2 −1
src/backend/access/nbtree/nbtsearch.c modified +4 −5
src/backend/access/nbtree/nbtsplitloc.c modified +1 −1
src/backend/access/rmgrdesc/dbasedesc.c modified +1 −1
src/backend/access/rmgrdesc/xactdesc.c modified +2 −2
src/backend/access/spgist/spgvalidate.c modified +1 −1
src/backend/access/transam/xact.c modified +3 −3
src/backend/access/transam/xlogarchive.c modified +2 −2
src/backend/access/transam/xlog.c modified +14 −9
src/backend/access/transam/xlogreader.c modified +5 −5
src/backend/catalog/genbki.pl modified +3 −3
src/backend/catalog/heap.c modified +4 −4
src/backend/catalog/pg_cast.c modified +7 −7
src/backend/catalog/pg_depend.c modified +2 −2
src/backend/catalog/pg_shdepend.c modified +2 −0
src/backend/catalog/storage.c modified +11 −11
src/backend/commands/alter.c modified +1 −1
src/backend/commands/dbcommands.c modified +5 −5
src/backend/commands/event_trigger.c modified +0 −6
src/backend/commands/explain.c modified +8 −8
src/backend/commands/extension.c modified +28 −28
src/backend/commands/functioncmds.c modified +1 −1
src/backend/commands/opclasscmds.c modified +3 −2
src/backend/commands/publicationcmds.c modified +4 −4
src/backend/commands/statscmds.c modified +4 −4
src/backend/commands/tablecmds.c modified +12 −11
src/backend/commands/trigger.c modified +2 −2
src/backend/executor/execExpr.c modified +1 −1
src/backend/executor/execExprInterp.c modified +37 −43
src/backend/executor/execGrouping.c modified +7 −7
src/backend/executor/execSRF.c modified +3 −3
src/backend/executor/execUtils.c modified +3 −3
src/backend/executor/nodeAgg.c modified +162 −161
src/backend/executor/nodeBitmapHeapscan.c modified +2 −2
src/backend/executor/nodeIncrementalSort.c modified +40 −31
src/backend/executor/nodeTidscan.c modified +1 −1
src/backend/jit/llvm/llvmjit_expr.c modified +18 −23
src/backend/libpq/auth-scram.c modified +9 −9
src/backend/libpq/be-secure-openssl.c modified +3 −2
src/backend/libpq/crypt.c modified +1 −1
src/backend/optimizer/path/allpaths.c modified +22 −19
src/backend/optimizer/path/costsize.c modified +31 −31
src/backend/optimizer/path/joinrels.c modified +11 −10
src/backend/optimizer/path/pathkeys.c modified +1 −1
src/backend/optimizer/plan/planner.c modified +35 −35
src/backend/parser/parse_clause.c modified +1 −1
src/backend/parser/parse_utilcmd.c modified +2 −2
src/backend/partitioning/partbounds.c modified +141 −136
src/backend/partitioning/partprune.c modified +2 −2
src/backend/postmaster/autovacuum.c modified +1 −1
src/backend/postmaster/checkpointer.c modified +11 −11
src/backend/postmaster/pgstat.c modified +6 −6
src/backend/postmaster/postmaster.c modified +2 −0
src/backend/replication/backup_manifest.c modified +6 −6
src/backend/replication/logical/relation.c modified +1 −1
src/backend/replication/pgoutput/pgoutput.c modified +8 −5
src/backend/replication/slotfuncs.c modified +6 −7
src/backend/replication/walreceiverfuncs.c modified +4 −4
src/backend/replication/walsender.c modified +3 −3
src/backend/statistics/dependencies.c modified +8 −6
src/backend/statistics/extended_stats.c modified +39 −33
src/backend/statistics/mcv.c modified +55 −53
src/backend/storage/buffer/bufmgr.c modified +1 −1
src/backend/storage/freespace/freespace.c modified +4 −2
src/backend/storage/ipc/latch.c modified +3 −3
src/backend/storage/ipc/procarray.c modified +2 −2
src/backend/storage/ipc/procsignal.c modified +40 −40
src/backend/storage/ipc/shmem.c modified +2 −2
src/backend/storage/lmgr/lock.c modified +1 −1
src/backend/storage/smgr/smgr.c modified +6 −6
src/backend/tcop/utility.c modified +23 −21
src/backend/utils/adt/datetime.c modified +8 −8
src/backend/utils/adt/int8.c modified +10 −9
src/backend/utils/adt/int.c modified +10 −9
src/backend/utils/adt/json.c modified +1 −1
src/backend/utils/adt/jsonfuncs.c modified +7 −6
src/backend/utils/adt/numutils.c modified +17 −15
src/backend/utils/adt/pgstatfuncs.c modified +7 −7
src/backend/utils/adt/rangetypes_spgist.c modified +5 −5
src/backend/utils/adt/regproc.c modified +2 −1
src/backend/utils/adt/ruleutils.c modified +8 −8
src/backend/utils/adt/tsgistidx.c modified +6 −6
src/backend/utils/cache/lsyscache.c modified +4 −4
src/backend/utils/cache/relcache.c modified +6 −5
src/backend/utils/error/elog.c modified +2 −2
src/backend/utils/hash/dynahash.c modified +4 −1
src/backend/utils/init/miscinit.c modified +1 −1
src/backend/utils/misc/guc.c modified +1 −1
src/backend/utils/mmgr/aset.c modified +5 −5
src/backend/utils/mmgr/mcxt.c modified +1 −1
src/backend/utils/mmgr/slab.c modified +4 −3
src/backend/utils/sort/logtape.c modified +23 −22
src/backend/utils/sort/tuplesort.c modified +7 −7
src/bin/initdb/initdb.c modified +10 −10
src/bin/pg_basebackup/pg_basebackup.c modified +3 −2
src/bin/pg_basebackup/t/010_pg_basebackup.pl modified +7 −6
src/bin/pgbench/pgbench.c modified +4 −4
src/bin/pgbench/t/001_pgbench_with_server.pl modified +70 −62
src/bin/pgbench/t/002_pgbench_no_server.pl modified +19 −6
src/bin/pg_checksums/pg_checksums.c modified +1 −1
src/bin/pg_dump/pg_dump.c modified +14 −12
src/bin/pg_dump/pg_dump.h modified +2 −2
src/bin/pg_dump/t/002_pg_dump.pl modified +7 −5
src/bin/pg_dump/t/003_pg_dump_with_server.pl modified +8 −8
src/bin/pg_rewind/libpq_fetch.c modified +1 −1
src/bin/pg_verifybackup/parse_manifest.h modified +10 −10
src/bin/pg_verifybackup/pg_verifybackup.c modified +5 −6
src/bin/pg_verifybackup/t/001_basic.pl modified +16 −13
src/bin/pg_verifybackup/t/002_algorithm.pl modified +8 −8
src/bin/pg_verifybackup/t/003_corruption.pl modified +57 −56
src/bin/pg_verifybackup/t/004_options.pl modified +51 −36
src/bin/pg_verifybackup/t/005_bad_manifest.pl modified +9 −11
src/bin/pg_verifybackup/t/006_encoding.pl modified +14 −10
src/bin/pg_verifybackup/t/007_wal.pl modified +18 −15
src/bin/psql/common.c modified +1 −1
src/bin/psql/describe.c modified +1 −1
src/bin/psql/mainloop.c modified +4 −5
src/bin/psql/tab-complete.c modified +2 −2
src/bin/scripts/createuser.c modified +2 −2
src/bin/scripts/t/090_reindexdb.pl modified +1 −1
src/bin/scripts/t/100_vacuumdb.pl modified +1 −2
src/common/jsonapi.c modified +8 −8
src/common/pg_lzcompress.c modified +1 −1
src/common/scram-common.c modified +1 −1
src/common/unicode/generate-norm_test_table.pl modified +2 −1
src/common/unicode/generate-unicode_combining_table.pl modified +26 −25
src/common/unicode/generate-unicode_normprops_table.pl modified +6 −4
src/common/unicode/generate-unicode_norm_table.pl modified +2 −2
src/common/unicode_norm.c modified +11 −11
src/include/access/tableam.h modified +4 −4
src/include/access/visibilitymap.h modified +1 −1
src/include/catalog/pg_publication.h modified +1 −1
src/include/catalog/pg_statistic_ext.h modified +1 −1
src/include/commands/dbcommands_xlog.h modified +1 −1
src/include/common/scram-common.h modified +1 −1
src/include/common/unicode_normprops_table.h modified +1 −1
src/include/executor/nodeAgg.h modified +7 −4
src/include/libpq/libpq-be.h modified +1 −1
src/include/libpq/scram.h modified +1 −1
src/include/lib/simplehash.h modified +6 −6
src/include/nodes/execnodes.h modified +11 −11
src/include/nodes/params.h modified +3 −3
src/include/nodes/pathnodes.h modified +3 −3
src/include/nodes/plannodes.h modified +1 −1
src/include/port.h modified +1 −1
src/include/port/win32.h modified +1 −1
src/include/replication/backup_manifest.h modified +1 −1
src/include/replication/logicalrelation.h modified +1 −1
src/include/replication/walreceiver.h modified +5 −5
src/include/statistics/extended_stats_internal.h modified +1 −1
src/include/statistics/statistics.h modified +2 −2
src/include/storage/shmem.h modified +1 −1
src/include/utils/lsyscache.h modified +1 −1
src/include/utils/rangetypes.h modified +4 −4
src/interfaces/ecpg/compatlib/informix.c modified +2 −2
src/interfaces/ecpg/pgtypeslib/dt_common.c modified +2 −1
src/interfaces/ecpg/pgtypeslib/timestamp.c modified +2 −1
src/interfaces/libpq/fe-auth-scram.c modified +1 −1
src/interfaces/libpq/fe-secure-openssl.c modified +18 −19
src/interfaces/libpq/libpq-fe.h modified +2 −2
src/pl/tcl/pltcl.c modified +6 −4
src/port/explicit_bzero.c modified +1 −1
src/test/authentication/t/001_password.pl modified +2 −1
src/test/authentication/t/002_saslprep.pl modified +2 −1
src/test/modules/dummy_index_am/dummy_index_am.c modified +6 −5
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c modified +4 −2
src/test/perl/PostgresNode.pm modified +3 −2
src/test/perl/TestLib.pm modified +3 −1
src/test/recovery/t/001_stream_rep.pl modified +13 −10
src/test/recovery/t/003_recovery_targets.pl modified +14 −8
src/test/recovery/t/006_logical_decoding.pl modified +13 −9
src/test/recovery/t/019_replslot_limit.pl modified +59 −30
src/test/ssl/t/001_ssltests.pl modified +30 −17
src/test/subscription/t/003_constraints.pl modified +4 −2
src/test/subscription/t/008_diff_schema.pl modified +7 −10
src/test/subscription/t/013_partition.pl modified +129 −151
src/tools/msvc/Mkvcbuild.pm modified +17 −15
src/tools/msvc/Solution.pm modified +18 −13
src/tools/msvc/vcregress.pl modified +1 −3
src/tools/pgindent/typedefs.list modified +103 −25
src/tools/version_stamp.pl modified +5 −5