Clean up most -Wunused-but-set-variable warnings from gcc 4.6

Peter Eisentraut <peter_e@gmx.net>

Commit: 5caa3479c2efd31fca1b271db687e5e57c7de2d4

Author: Peter Eisentraut <peter_e@gmx.net>

Date: 2011-04-11T19:28:45Z

Clean up most -Wunused-but-set-variable warnings from gcc 4.6

This warning is new in gcc 4.6 and part of -Wall.  This patch cleans
up most of the noise, but there are some still warnings that are
trickier to remove.

Files

Path	Change	+/−
contrib/isn/isn.c	modified	+4 −6
contrib/pageinspect/fsmfuncs.c	modified	+0 −2
contrib/pgcrypto/pgp-s2k.c	modified	+3 −9
contrib/pgcrypto/px.c	modified	+1 −5
contrib/pgcrypto/px-hmac.c	modified	+0 −2
contrib/seg/seg.c	modified	+1 −2
src/backend/access/gist/gistvacuum.c	modified	+0 −5
src/backend/access/nbtree/nbtpage.c	modified	+1 −2
src/backend/catalog/pg_proc.c	modified	+0 −4
src/backend/catalog/toasting.c	modified	+1 −2
src/backend/commands/explain.c	modified	+0 −2
src/backend/commands/tablecmds.c	modified	+0 −2
src/backend/commands/tsearchcmds.c	modified	+1 −3
src/backend/commands/vacuum.c	modified	+1 −5
src/backend/executor/nodeHashjoin.c	modified	+0 −2
src/backend/executor/nodeMergejoin.c	modified	+0 −2
src/backend/executor/nodeRecursiveunion.c	modified	+2 −5
src/backend/foreign/foreign.c	modified	+0 −3
src/backend/libpq/auth.c	modified	+3 −4
src/backend/optimizer/geqo/geqo_main.c	modified	+7 −4
src/backend/parser/parse_utilcmd.c	modified	+1 −2
src/backend/rewrite/rewriteDefine.c	modified	+1 −2
src/backend/storage/ipc/standby.c	modified	+0 −4
src/backend/storage/smgr/md.c	modified	+1 −2
src/backend/utils/adt/ri_triggers.c	modified	+0 −3
src/backend/utils/adt/selfuncs.c	modified	+0 −6
src/bin/pg_dump/common.c	modified	+15 −30
src/bin/pg_dump/pg_backup_custom.c	modified	+1 −2
src/bin/pg_dump/pg_dumpall.c	modified	+3 −9
src/bin/pg_dump/pg_dump.c	modified	+3 −34
src/bin/psql/psqlscan.l	modified	+2 −5
src/interfaces/ecpg/ecpglib/descriptor.c	modified	+10 −13
src/interfaces/libpq/fe-auth.c	modified	+2 −3
src/pl/plpgsql/src/pl_exec.c	modified	+0 −2