Improve wait logic in TAP tests for streaming replication.
Tom Lane <tgl@sss.pgh.pa.us>
Improve wait logic in TAP tests for streaming replication. Remove hard-wired sleep(2) delays in 001_stream_rep.pl in favor of using poll_query_until to check for the desired state to appear. In addition, add such a wait before the last test in the script, as it's possible to demonstrate failures there after upcoming improvements in pg_ctl. (We might end up adding polling before each of the get_slot_xmins calls in this script, but I feel no great need to do that until shown necessary.) In passing, clarify the description strings for some of the test cases. Michael Paquier and Craig Ringer, pursuant to a complaint from me Discussion: https://postgr.es/m/8962.1498425057@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/test/recovery/t/001_stream_rep.pl | modified | +45 −20 |
Discussion
- Timing-sensitive case in src/test/recovery TAP tests 16 messages · 2017-06-25 → 2017-08-13