pg_dump: Lock all relations, not just plain tables

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 59b6b1fd9ecafe42b7c284f246e7c130d60cbb20
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-10-27T17:31:37Z
Releases: 11.10
pg_dump: Lock all relations, not just plain tables

Now that LOCK TABLE can take any relation type, acquire lock on all
relations that are to be dumped.  This prevents schema changes or
deadlock errors that could cause a dump to fail after expending much
effort.  The server is tested to have the capability and the feature
disabled if it doesn't, so that a patched pg_dump doesn't fail when
connecting to an unpatched server.

Backpatch to 9.5.

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reported-by: Wells Oliver <wells.oliver@gmail.com>
Discussion: https://postgr.es/m/20201021200659.GA32358@alvherre.pgsql

Files

PathChange+/−
src/bin/pg_dump/pg_backup_db.c modified +65 −0
src/bin/pg_dump/pg_backup_db.h modified +2 −0
src/bin/pg_dump/pg_backup.h modified +2 −0
src/bin/pg_dump/pg_dump.c modified +10 −7

Discussion

Cited messages not in the archive: 20201021200659.GA32358@alvherre.pgsql