Another round of cleanups for dynahash.c (maybe it's finally clean of
Tom Lane <tgl@sss.pgh.pa.us>
Another round of cleanups for dynahash.c (maybe it's finally clean of portability issues). Caller-visible data structures are now allocated on MAXALIGN boundaries, allowing safe use of datatypes wider than 'long'. Rejigger hash_create API so that caller specifies size of key and total size of entry, not size of key and size of rest of entry. This simplifies life considerably since each number is just a sizeof(), and padding issues etc. are taken care of automatically.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/transam/xlogutils.c | modified | +6 −6 |
| src/backend/postmaster/pgstat.c | modified | +58 −51 |
| src/backend/storage/buffer/buf_init.c | modified | +3 −7 |
| src/backend/storage/buffer/buf_table.c | modified | +16 −28 |
| src/backend/storage/freespace/freespace.c | modified | +7 −12 |
| src/backend/storage/ipc/shmem.c | modified | +11 −13 |
| src/backend/storage/lmgr/lock.c | modified | +21 −20 |
| src/backend/storage/smgr/mm.c | modified | +26 −23 |
| src/backend/utils/adt/ri_triggers.c | modified | +15 −12 |
| src/backend/utils/cache/relcache.c | modified | +17 −13 |
| src/backend/utils/hash/dynahash.c | modified | +229 −329 |
| src/backend/utils/hash/hashfn.c | modified | +53 −107 |
| src/backend/utils/mmgr/portalmem.c | modified | +2 −2 |
| src/include/storage/buf_internals.h | modified | +8 −1 |
| src/include/storage/lock.h | modified | +1 −7 |
| src/include/storage/shmem.h | modified | +2 −4 |
| src/include/utils/hsearch.h | modified | +51 −49 |