Fix portability issues in datetime parsing.
Tom Lane <tgl@sss.pgh.pa.us>
Fix portability issues in datetime parsing. datetime.c's parsing logic has assumed that strtod() will accept a string that looks like ".", which it does in glibc, but not on some less-common platforms such as AIX. The result of this was that datetime fields like "123." would be accepted on some platforms but not others; which is a sufficiently odd case that it's not that surprising we've heard no field complaints. But commit e39f99046 extended that assumption to new places, and happened to add a test case that exposed the platform dependency. Remove this dependency by special-casing situations without any digits after the decimal point. (Again, this is in part a pre-existing bug but I don't feel a compulsion to back-patch.) Also, rearrange e39f99046's changes in formatting.c to avoid a Coverity complaint that we were copying an uninitialized field. Discussion: https://postgr.es/m/1592893.1648969747@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/adt/datetime.c | modified | +77 −28 |
| src/backend/utils/adt/formatting.c | modified | +12 −8 |
| src/test/regress/expected/interval.out | modified | +35 −0 |
| src/test/regress/sql/interval.sql | modified | +8 −0 |
Discussion
- Fix overflow in DecodeInterval 42 messages · 2022-02-11 → 2022-04-03