Remove empty function BufmgrCommit().
Tom Lane <tgl@sss.pgh.pa.us>
Remove empty function BufmgrCommit(). This function has been a no-op for over a decade. Even if bufmgr regains a need to be called during commit, it seems unlikely that the most appropriate call points would be precisely here, so it's not doing us much good as a placeholder either. Now, removing it probably doesn't save any noticeable number of cycles --- but the main call is inside the commit critical section, and the less work done there the better. Matthias van de Meent Discussion: https://postgr.es/m/CAEze2Wi1=tLKbxZnXzcD+8fYKyKqBtivVakLQC_mYBsP4Y8qVA@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/transam/xact.c | modified | +3 −9 |
| src/backend/storage/buffer/bufmgr.c | modified | +0 −10 |
| src/include/storage/bufmgr.h | modified | +0 −1 |
Discussion
- BufmgrCommit no-op since 2008, remaining uses? 4 messages · 2023-03-29