Fix incorrect calculation in BlockRefTableEntryGetBlocks.
Robert Haas <rhaas@postgresql.org>
Fix incorrect calculation in BlockRefTableEntryGetBlocks. The previous formula was incorrect in the case where the function's nblocks argument was a multiple of BLOCKS_PER_CHUNK, which happens whenever a relation segment file is exactly 512MB or exactly 1GB in length. In such cases, the formula would calculate a stop_offset of 0 rather than 65536, resulting in modified blocks in the second half of a 1GB file, or all the modified blocks in a 512MB file, being omitted from the incremental backup. Reported off-list by Tomas Vondra and Jakub Wartak. Discussion: http://postgr.es/m/CA+TgmoYwy_KHp1-5GYNmVa=zdeJWhNH1T0SBmEuvqQNJEHj1Lw@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/common/blkreftable.c | modified | +5 −1 |
Discussion
- incremental backup breakage in BlockRefTableEntryGetBlocks 4 messages · 2024-04-04 → 2024-04-05