Remove pg_rewind's private logging.h/logging.c files.
Tom Lane <tgl@sss.pgh.pa.us>
Remove pg_rewind's private logging.h/logging.c files. The existence of these files became rather confusing with the introduction of a widely-known logging.h header in commit cc8d41511. (Indeed, there's already some duplicative #includes here, perhaps betraying such confusion.) The only thing left in them, after that commit, is a progress-reporting function that's neither general-purpose nor tied in any way to other logging infrastructure. Hence, let's just move that function to pg_rewind.c, and get rid of the separate files. Discussion: https://postgr.es/m/3971.1557787914@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/pg_rewind/copy_fetch.c | modified | +0 −1 |
| src/bin/pg_rewind/filemap.c | modified | +0 −2 |
| src/bin/pg_rewind/file_ops.c | modified | +0 −1 |
| src/bin/pg_rewind/libpq_fetch.c | modified | +0 −2 |
| src/bin/pg_rewind/logging.c | deleted | +0 −79 |
| src/bin/pg_rewind/logging.h | deleted | +0 −25 |
| src/bin/pg_rewind/Makefile | modified | +1 −1 |
| src/bin/pg_rewind/nls.mk | modified | +1 −1 |
| src/bin/pg_rewind/parsexlog.c | modified | +0 −1 |
| src/bin/pg_rewind/pg_rewind.c | modified | +60 −2 |
| src/bin/pg_rewind/pg_rewind.h | modified | +12 −0 |
| src/bin/pg_rewind/timeline.c | modified | +0 −1 |
Discussion
- PG12, PGXS and linking pgfeutils 11 messages · 2019-05-07 → 2019-05-14