Code review for postmaster.pid contents changes.
Tom Lane <tgl@sss.pgh.pa.us>
Code review for postmaster.pid contents changes. Fix broken test for pre-existing postmaster, caused by wrong code for appending lines to the lockfile; don't write a failed listen_address setting into the lockfile; don't arbitrarily change the location of the data directory in the lockfile compared to previous releases; provide more consistent and useful definitions of the socket path and listen_address entries; avoid assuming that pg_ctl has the same DEFAULT_PGSOCKET_DIR as the postmaster; assorted code style improvements.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/storage.sgml | modified | +8 −3 |
| src/backend/port/ipc_test.c | modified | +2 −2 |
| src/backend/port/sysv_shmem.c | modified | +7 −6 |
| src/backend/postmaster/postmaster.c | modified | +18 −17 |
| src/backend/utils/init/miscinit.c | modified | +40 −37 |
| src/bin/pg_ctl/pg_ctl.c | modified | +93 −92 |
| src/include/miscadmin.h | modified | +26 −2 |