Fix plpgsql to enforce domain checks when returning a NULL domain value.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 51db0d18fbf58b0c2e5ebc2b5b2c48daf45c8d93
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2018-02-15T21:25:19Z
Releases: 11.0
Fix plpgsql to enforce domain checks when returning a NULL domain value.

If a plpgsql function is declared to return a domain type, and the domain's
constraints forbid a null value, it was nonetheless possible to return
NULL, because we didn't bother to check the constraints for a null result.
I'd noticed this while fooling with domains-over-composite, but had not
gotten around to fixing it immediately.

Add a regression test script exercising this and various other domain
cases, largely borrowed from the plpython_types test.

Although this is clearly a bug fix, I'm not sure whether anyone would
thank us for changing the behavior in stable branches, so I'm inclined
not to back-patch.

Files