Improve division of labor between execParallel.c and nodeGather[Merge].c.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 51daa7bdb39e1bdc31eb99fd3f54f61743ebb7ae
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-09-01T21:39:01Z
Releases: 11.0
Improve division of labor between execParallel.c and nodeGather[Merge].c.

Move the responsibility for creating/destroying TupleQueueReaders into
execParallel.c, to avoid duplicative coding in nodeGather.c and
nodeGatherMerge.c.  Also, instead of having DestroyTupleQueueReader do
shm_mq_detach, do it in the caller (which is now only ExecParallelFinish).
This means execParallel.c does both the attaching and detaching of the
tuple-queue-reader shm_mqs, which seems less weird than the previous
arrangement.

These changes also eliminate a vestigial memory leak (of the pei->tqueue
array).  It's now demonstrable that rescans of Gather or GatherMerge don't
leak memory.

Discussion: https://postgr.es/m/8670.1504192177@sss.pgh.pa.us

Files

Discussion