Code review for function default parameters patch. Fix numerous problems as

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 517ae4039ebe12806d76adfd3bc1fc6578fc8862

Author: Tom Lane <tgl@sss.pgh.pa.us>

Date: 2008-12-18T18:20:35Z

Code review for function default parameters patch.  Fix numerous problems as
per recent discussions.  In passing this also fixes a couple of bugs in
the previous variadic-parameters patch.

Files

Path	Change	+/−
doc/src/sgml/catalogs.sgml	modified	+23 −2
doc/src/sgml/func.sgml	modified	+4 −5
doc/src/sgml/ref/create_function.sgml	modified	+22 −10
doc/src/sgml/typeconv.sgml	modified	+15 −2
doc/src/sgml/xfunc.sgml	modified	+16 −17
src/backend/catalog/namespace.c	modified	+158 −147
src/backend/catalog/pg_aggregate.c	modified	+4 −4
src/backend/catalog/pg_proc.c	modified	+56 −7
src/backend/commands/functioncmds.c	modified	+45 −21
src/backend/commands/proclang.c	modified	+7 −7
src/backend/optimizer/plan/planner.c	modified	+8 −17
src/backend/optimizer/util/clauses.c	modified	+96 −12
src/backend/parser/gram.y	modified	+12 −11
src/backend/parser/parse_func.c	modified	+71 −22
src/backend/utils/adt/regproc.c	modified	+4 −4
src/backend/utils/adt/ruleutils.c	modified	+54 −46
src/bin/pg_dump/pg_dump.c	modified	+7 −6
src/include/catalog/namespace.h	modified	+5 −3
src/include/catalog/pg_attribute.h	modified	+2 −2
src/include/catalog/pg_proc_fn.h	modified	+3 −3
src/include/catalog/pg_proc.h	modified	+9 −7
src/include/nodes/parsenodes.h	modified	+4 −4
src/include/parser/parse_func.h	modified	+3 −2
src/test/regress/expected/opr_sanity.out	modified	+5 −3
src/test/regress/expected/polymorphism.out	modified	+110 −46
src/test/regress/sql/opr_sanity.sql	modified	+5 −3
src/test/regress/sql/polymorphism.sql	modified	+49 −26